ISPN-1102 Adaptive marshaller buffer sizes #338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param previousSize int representing the size of the last | ||
| * object buffered. | ||
| */ | ||
| void calculateNextSize(int previousSize); |
There was a problem hiding this comment.
How about recordSize(size) instead? calculateNextSize(size) makes it seem like the next size will only depend on the size passed in.
There was a problem hiding this comment.
Yeah, you're right. calculateNextSize() is an implementation detail. I like recordSize() name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-1102
Use an adaptive buffer algorithm based on Netty's adaptive buffer size predictor. Byte buffers that are way off are trimmed as well, but the trimming is limited to way off predictions, so extra memory should be small.